lostisland / lostisland/faraday_middleware
missing tests for parallel caching feature
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 558
- Forks
- 196
- PR merge metrics
- No merged PRs in 30d
Description
Looks like in a83b39c6, the if env[:parallel_manager] condition and the cache_on_complete method it uses were not tested.
The feature itself seems like a bit of a smell — why would the concurrent case not work with threadsafe code?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting commit a83b39c6 and the existing test suite for the code containing the if env[:parallel_manager] condition. Trace how that branch reaches cache_on_complete, then add coverage for the parallel path and the method's behavior. Done means the relevant caching behavior is exercised by tests and the suite passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100