lostisland / lostisland/faraday-em_http

Ruby 3.4 tests: mock requests correctly

Open
#13 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1
Forks
5
PR merge metrics
No merged PRs in 30d

Description

I had the Ruby 3.4 in the test matrix, and I had lots of test failures. I removed it, and created this issue instead.

Errors included: "unable to resolve address: Name or service not known"

```
expected Faraday::ProxyAuthError, got #> with backtrace:
```

To see the issue:

- [ ] Install Ruby 3.4
- [ ] `bundle`
- [ ] `bundle exec rake`

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by installing Ruby 3.4, running bundle, and reproducing the failures with bundle exec rake. Inspect the failing tests that expect Faraday::ProxyAuthError and identify where requests are reaching DNS instead of being mocked. Done means the test suite passes on Ruby 3.4 without resolving external addresses.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.