Position may change when assigning Actor.image etc
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 611
- Forks
- 211
- PR merge metrics
- No merged PRs in 30d
Description
After landing #130 we are able to set opacity and angle but the positioning of Actor is becoming increasingly broken.
Our approach of using an underlying ZRect and recalculating pos is not ideal. pos needs to change only when users assign to one of the positioning attributes. Therefore it would be simpler to store pos and calculate the values of positioning attributes.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Actor's positioning implementation and the underlying ZRect behavior described in the issue, then review the changes from #130. Done means storing pos directly, ensuring image and other non-positioning assignments do not move the Actor, and recalculating position values only when positioning attributes are assigned.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100