loopbackio / loopbackio/loopback-connector

`Connector.prototype.isRelational` returns a function

Open
#220 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
35
Forks
102
Avg merge
14h 26m
Merged PRs (30d)
13

Description

## Steps to reproduce

Call `new Connector(/*...*/).isRelational()`

Offending line:

https://github.com/loopbackio/loopback-connector/blob/e85797318c76890c387050c39e84e09cc83214a2/lib/connector.js#L36-L37

## Current Behavior

It returns itself (a function), which then requires a 2nd call to get the expected boolean value.

## Expected Behavior

`Connector.prototype.isRelational` should strictly return a boolean.

## Link to reproduction sandbox

N/A

## Additional information

## Related Issues

_See [Reporting Issues](http://loopback.io/doc/en/contrib/Reporting-issues.html) for more tips on writing good issues_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/connector.js at lines 36-37 and reproduce the behavior by calling new Connector(/*...*/).isRelational(). Confirm that the method directly returns a boolean on its first call, matching the expected behavior described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.