loopbackio / loopbackio/loopback-connector-mongodb

Remove references to internal APIs

Open
#724 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug v7.x
Dominant language
JavaScript
Stars
186
Forks
238
Avg merge
2h 49m
Merged PRs (30d)
1

Description

MongoDB native driver v4.5.0 has marked existing APIs, of which `Topology` is utilised by this connector, as internal (PR: https://github.com/mongodb/node-mongodb-native/pull/2810, issue: https://jira.mongodb.org/browse/NODE-3245). It should be noted that these APIs have always intended to be internal, and that the added internal markings in v4.5.0 are a formality.

This connector references `Topology` APIs at these locations:

- https://github.com/loopbackio/loopback-connector-mongodb/blob/21a25fe8f42073c85784fe7e19f6272495a0fada/lib/mongodb.js#L527
- https://github.com/loopbackio/loopback-connector-mongodb/blob/21a25fe8f42073c85784fe7e19f6272495a0fada/lib/mongodb.js#L531

This issue is to track replacing references to these APIs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in lib/mongodb.js at the references around lines 527 and 531, then read the MongoDB native driver v4.5.0 internal-API context and the linked PR and issue. Replace the connector's references to the internal Topology APIs; the work is done when those references no longer remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, mongodb, node.js
Domain
backend, databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.