loopbackio / loopbackio/cicd

Pin NPM version installed by CI pipelines

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
0
Forks
0
Avg merge
1d 3h
Merged PRs (30d)
2

Description

When LoopBack's CI pipelines started incorporating GitHub Actions, `npm install --global npm` was added as a step performed before installation. This was to prevent an issue where, under certain circumstances, the Mocha tests would silently pass without even executing the tests themselves. However, a side-effect was that this would install the latest NPM version. This meant that CI pipelines which still tested against Node.js v10 broke due to incompatibility with the newly-relesaed NPM v8.

The NPM version policy is as follows:

1. Use the latest supported NPM version for that specific Node.js version.
2. Where there may be a gap between NPM major versions in the test matrix, add an additional x86 Linux test matrix permutation on GitHub Actions.

This issue is to track the updating of CI pipelines to use pinned NPM major versions.

Repos to update:
- [x] strong-soap (PR: https://github.com/loopbackio/strong-soap/pull/343)
- [x] loopback-connector (PR: https://github.com/loopbackio/loopback-connector/pull/192)
- [x] loopback-connector-mongodb
- - [x] v6.x (PR: https://github.com/loopbackio/loopback-connector-mongodb/pull/652)
- - ~v5.x~ (Not applicable)
- [x] loopback-connector-grpc (PR: https://github.com/loopbackio/loopback-connector-grpc/pull/17)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the GitHub Actions CI pipeline definitions in the listed repositories, starting with the npm install --global npm step and each Node.js test-matrix entry. Compare them with the stated NPM version policy and confirm the listed repositories are updated; the checklist and linked PRs indicate this work is already complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, node.js, shell
Domain
ci-cd
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.