lookit / lookit/lookit-api

Drop DinD; use normal k8s workload for ember builds

Open
#566 0 comments 0 reactions 1 assignee Claimed by @Datamance View on GitHub
Cleanup Developer Large
Dominant language
Python
Stars
12
Forks
21
Avg merge
5d 19h
Merged PRs (30d)
5

Description

**TL;DR**: There is really no good reason to be using DinD. We already have containerized workloads. "Turtles all the way down" is not a design pattern. Furthermore, privileged containers are [a _bad_ idea](https://www.trendmicro.com/en_us/research/19/l/why-running-a-privileged-container-in-docker-is-a-bad-idea.html) from a security standpoint.

By taking the build process "out of the nest", we will save space, time, and cloud platform expenses.

**Narrative**
As a Developer, I want the ember build process to be as simple as possible, and to employ no more resources than are needed. The existence of superfluous nested containers is not only confusing and unnecessarily convoluted, but potentially insecure.

**Acceptance Criteria**

- [ ] Builder workloads no longer use the DinD container
- [ ] New tests for build process!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.