lookit / lookit/lookit-api

Experiment build script fails silently.

Open
#1,246 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
12
Forks
21
Avg merge
5d 19h
Merged PRs (30d)
5

Description

**Description**
When the experiment `build.sh` script fails, the error is not reported. It quietly fails.

**How to reproduce**
Edit the `build.sh` script to fail and build an experiment. The only indication that it failed is there's no output files.

**Expected behavior**
The user would get an email reporting the error.

**Additional context**
The solution might be adding `SHELL ["/bin/bash", "-o", "pipefail", "-c"]` to the build Dockerfile.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the experiment build.sh script and the build Dockerfile, then reproduce a failing experiment build as described. Check how the failure is currently handled and how email reporting is triggered. Done means a failed build reports an error to the user instead of only producing no output files.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
build-system, devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.