lookit / lookit/lookit-api

2fa tests passing in local but failing in CI

Open
#1,055 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bg-priority Developer
Dominant language
Python
Stars
12
Forks
21
Avg merge
5d 19h
Merged PRs (30d)
5

Description

**TL;DR**: A few tests to prove the new authenticated redirect works as expected fail in CI.

**Narrative**
These tests where passing in the local environment, but fail in CI. This caused a weeks worth of research to figure out why and at the end it seems to be related to the ENVIRONMENT value set in the .env file. When this value is unset, the tests seem to fail.
These tests in question are marked as "skip" and in the skip note will be this issue number.

**Acceptance Criteria**
These tests need to be refactored to pass in CI.

**Implementation Notes**
These tests are failing due to something with either 2fa or revproxy.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the skipped tests for the authenticated redirect and inspect their skip notes for issue 1055. Compare CI behavior with the local environment, especially when the .env ENVIRONMENT value is unset, and investigate the reported 2FA or reverse-proxy interaction. Done means the relevant tests run successfully in CI without being skipped.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
authentication, ci-cd, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.