loktar00 / loktar00/react-lazy-load
shouldComponentUpdate returns true when the item is visible
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 980
- Forks
- 163
- PR merge metrics
- No merged PRs in 30d
Description
Hey there!
Im trying to understand whats the reason for the shouldcomponentupdate logic that you are applying.
```
shouldComponentUpdate(_nextProps, nextState) {
return nextState.visible;
}
```
If the current state is visible and the next one is also visible then why should i update the component?
i would think that the wanted behavior should be:
```
shouldComponentUpdate(_nextProps, nextState) {
return !this.state.visible && nextState.visible;
}
```
What am i missing here?
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the component's shouldComponentUpdate implementation and trace how visible changes as items enter the viewport. Compare the current and next state behavior, then inspect any existing component tests to determine the expected update semantics; no test path is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100