loktar00 / loktar00/JQuery-Snowfall
Only show image base snowflakes after the image has fully loaded
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 715
- Forks
- 218
- PR merge metrics
- No merged PRs in 30d
Description
If the loading of the snowflake image takes a long time, empty placeholders can be seen, what looks very ugly!
Please insert following 2 lines of code after line 140 (jQuery variant):
$(flakeMarkup).css('display','none'); // Only show the snowflake after the image has been loaded
flakeMarkup.onload = function () {$(flakeMarkup).css('display','block');};
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the jQuery variant around line 140 and inspect how the snowflake image element is created. Ensure the placeholder stays hidden until the image has fully loaded, then verify that loaded snowflakes display normally without empty placeholders.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100