lokenx / lokenx/plexrequests-meteor

When auto approve is disabled an error occurs on v1.21.0

Open
#517 7 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
521
Forks
129
PR merge metrics
No merged PRs in 30d

Description

When auto approve is disabled the following issues occurs:

Branch: master
Version: v1.21.0

`Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.527(-5)? #033[39mException while invoking method 'requestMovie' TypeError: Cannot read property 'permAPPROVAL' of undefined
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.527(-5)? #033[39m at [object Object].Meteor.methods.requestMovie (server/methods/search/requestMovie.js:115:1)
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.527(-5)? #033[39m at maybeAuditArgumentChecks (livedata_server.js:1698:12)
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.527(-5)? #033[39m at livedata_server.js:708:19
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.528(-5)? #033[39m at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.528(-5)? #033[39m at livedata_server.js:706:40
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.528(-5)? #033[39m at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.529(-5)? #033[39m at livedata_server.js:704:46
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.529(-5)? #033[39m at tryCallTwo (/home/plex/.meteor/packages/promise/.0.5.1.dqgple++os+web.browser+web.cordova/npm/node_modules/meteor-promise/node_modules/promise/lib/core.js:45:5)
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.529(-5)? #033[39m at doResolve (/home/plex/.meteor/packages/promise/.0.5.1.dqgple++os+web.browser+web.cordova/npm/node_modules/meteor-promise/node_modules/promise/lib/core.js:171:13)
Jan 7 18:53:57 requests meteor: #033[34mI20180107-18:53:57.529(-5)? #033[39m at new Promise (/home/plex/.meteor/packages/promise/.0.5.1.dqgple++os+web.browser+web.cordova/npm/node_modules/meteor-promise/node_modules/promise/lib/core.js:65:3)
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.882(-5)? #033[39mException while invoking method 'requestMovie' TypeError: Cannot read property 'permAPPROVAL' of undefined
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.882(-5)? #033[39m at [object Object].Meteor.methods.requestMovie (server/methods/search/requestMovie.js:115:1)
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.882(-5)? #033[39m at maybeAuditArgumentChecks (livedata_server.js:1698:12)
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.882(-5)? #033[39m at livedata_server.js:708:19
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.883(-5)? #033[39m at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.883(-5)? #033[39m at livedata_server.js:706:40
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.883(-5)? #033[39m at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.883(-5)? #033[39m at livedata_server.js:704:46
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.884(-5)? #033[39m at tryCallTwo (/home/plex/.meteor/packages/promise/.0.5.1.dqgple++os+web.browser+web.cordova/npm/node_modules/meteor-promise/node_modules/promise/lib/core.js:45:5)
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.884(-5)? #033[39m at doResolve (/home/plex/.meteor/packages/promise/.0.5.1.dqgple++os+web.browser+web.cordova/npm/node_modules/meteor-promise/node_modules/promise/lib/core.js:171:13)
Jan 7 18:53:59 requests meteor: #033[34mI20180107-18:53:59.884(-5)? #033[39m at new Promise (/home/plex/.meteor/packages/promise/.0.5.1.dqgple++os+web.browser+web.cordova/npm/node_modules/meteor-promise/node_modules/promise/lib/core.js:65:3)
`

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in server/methods/search/requestMovie.js at line 115 and reproduce a movie request with auto approval disabled on v1.21.0. Trace the undefined value behind permAPPROVAL and verify that requestMovie completes without the reported TypeError when auto approval is disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.