switching day/night theme should change pdf viewer's light/dark state
Open
Nobody has claimed this yet.
:type/enhancement
pdf
themes
- Dominant language
- Clojure
- Stars
- 45k
- Forks
- 2.8k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 105
Description
What happened?
When using the pdf viewer, I can change the logseq theme to night mode easily using shortcut t t but it does not reflect in the PDF reader (I have to manually click on the "More settings" button of the PDF toolbar
Reproduce the Bug
- open a pdf in logseq
- press
ttwice while focussing on the regular area (i.e. not the pdf reader area) to switch the theme to night theme - notice that the theme of the PDF stays unchanged
Expected Behavior
Changing the theme should change the PDF theme as well.
Screenshots
No response
Desktop Platform Information
Linux : Logseq 0.7.2
Mobile Platform Information
No response
Additional Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by tracing the PDF viewer's “More settings” theme control and the global t t theme-switch path; done means switching Logseq to night mode also changes the open PDF viewer state without manual toolbar interaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100