logseq / logseq/logseq

Highlighting syntax is not valid for text containing line breaks.

Open
#5,602 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

:type/bug parser
Dominant language
Clojure
Stars
45k
Forks
2.8k
Avg merge
1d 22h
Merged PRs (30d)
105

Description

### What happened?

Highlighting syntax is just valid for text in a line.
If the text highlighted is with multi-lines (in a block), the highlight is not valid.
This appears on both Windows and Android platforms.
Additionally, the same highlighting syntax is valid in Obsidian.

### Reproduce the Bug

1. In a block, write text with multi-lines
2. Highlight the text using "==" or "^^^^"

### Expected Behavior

Fix the bug

### Screenshots

- Appearance on Logseq for Windows

![image](https://user-images.githubusercontent.com/62691819/172403597-6185a94b-949c-4555-8a01-0d807f7a9ed6.png)

- Appearance on Logseq for Android

![image](https://user-images.githubusercontent.com/62691819/172405461-9a23964a-cdbf-42ab-afa0-e38d5555343f.png)

- Appearance on Obsidian

![image](https://user-images.githubusercontent.com/62691819/172404642-eb1f307d-a29c-4aea-aabe-7ae4019be5d3.png)

### Desktop Platform Information

Windows 10, 21H2
Loqseq 0.7.1

### Mobile Platform Information

Huawei mate 10, Harmony OS 2.0.0
Loqseq 0.7.1

### Additional Context

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the multiline highlighting case on Windows or Android, then trace the rendering path for the == and ^^^^ syntax. Done means highlighted multiline blocks render correctly on the affected platforms and the behavior matches the expected result shown in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure, markdown
Domain
content, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.