logseq / logseq/logseq

annotations in pdf don't work when crossing a page boundary

Open
#11,294 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

:type/enhancement pdf
Dominant language
Clojure
Stars
45k
Forks
2.8k
Avg merge
1d 22h
Merged PRs (30d)
105

Description

Search first
  • I searched and no similar issues were found
What Happened?

i have a pdf document of about 70 pages.
when i make text annotations (highlights) it generally works well, as long as the text is within the same page.
when i make a text annotation that covers text from the end of one page, to the beginning of the next, the software gets confused. it never highlights the part of the text on the second page. on the first page, sometimes it highlights all the text on the first page instead.

Reproduce the Bug
  1. download https://cartographicperspectives.org/index.php/journal/article/view/cp43-complete-issue/pdf (this is just a random pdf file i found online for testing, there's probably many other examples we can use)
  2. import in logseq and open it
  3. find some text between two pages and try to highlight it, like on page 4 to page 5 for example

logseq-1
5. click a color to highlight. note that it highlighted the wrong text!
6.
logseq-2

Expected Behavior

No response

Screenshots

No response

Desktop or Mobile Platform Information

logseq 0.10.7 on arch linux

Additional Context

No response

Are you willing to submit a PR? If you know how to fix the bug.
  • I'm willing to submit a PR (Thank you!)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Logseq 0.10.7 using the linked PDF, selecting text across pages 4 and 5. Trace the PDF annotation flow from that interaction; done means the selection highlights the intended text on both pages without highlighting unrelated text on the first page.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.