logseq / logseq/logseq

Keymap editor shows wrong shortcuts (maj instead of ctrl)

Open
#10,418 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
45k
Forks
2.8k
Avg merge
1d 22h
Merged PRs (30d)
105

Description

### Search first

- [X] I searched and no similar issues were found

### What Happened?

I was trying out the zoom feature. I read on the wiki that on Windows zooming in is with "Ctrl" + "+", which indeed works.

However, on the keymap page, it's shown as "Maj" + "+", which doesn't do anything.

The other zoom controls also share this same issue.

I haven't checked whether this is specific to zoom commands but it's probably not.

### Reproduce the Bug

Open keymap and look at the default "Zoom in" shortcut: it displays "shift +" instead of "control +"

### Expected Behavior

_No response_

### Screenshots

PS: I'm on AZERTY

![image](https://github.com/logseq/logseq/assets/6502864/bd5fa1d1-ce1f-497e-b18f-ff1fc51bfcb9)

### Desktop or Mobile Platform Information

Windows 10, Desktop app 0.9.19

### Additional Context

_No response_

### Are you willing to submit a PR? If you know how to fix the bug.

- [ ] I'm willing to submit a PR (Thank you!)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the keymap editor and trace how the default Zoom in shortcut is displayed, comparing the rendered modifier with the shortcut that works on Windows. Check the other zoom controls and confirm that the displayed modifier is control rather than shift before considering the issue done.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
desktop, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.