Autocomplete menu shifted left out of the visible area and occluded by utility pane to the left
Nobody has claimed this yet.
- Dominant language
- Clojure
- Stars
- 45k
- Forks
- 2.8k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 105
Description
Search first
- I searched and no similar issues were found
What Happened?
When one or more of the sidebars are open, the autocomplete menu is hidden / concealed / occluded / covered up (including all these terms so other users can search for this issue).
When typing a new page reference, for example, that appears when typing [[My Tag, the autocomplete menu ends up shifted to the left so far as to be useless.
Expected Behavior
The autocomplete menu appears in the visible area, on top of any other visual elements.
Actual Behavior
The autocomplete menu starts shifted to the left, in a covered up, non-visible area that ends in the visible area.
Example with left sidebar and right sidebar open
Example with PDF open and right sidebar open
Example with substantial occlusion
Example in right sidebar
Reproduce the Bug
- I have a hypothesis that the bug is related to some kind of offset in the autocomplete window of the main area when the utility panes are open. It is likely also related to an insufficient z-index of the autocomplete modal relative to the other panes.
- Most often it occurs when candidate commands appear in the autocomplete list that are long, and one or more of the sidebars are open.
- The bug is not reproducible with all utility panes minimized.
It is also not reproducible when typing an autocomplete reference into the right sidebar(Update - it is reproducible in this context; see screenshot under heading "example in right sidebar" above). By utility panes I mean the PDF view, left sidebar and right sidebars. - I have not completely isolated the reproduction criteria.
While I have not attempted to duplicate this outside of my graph, I think it would be easy to do so:
- Create a new graph
- Create many hierarchical page references that have various name lengths, some over 50 characters. Create ~50-10
- Upload a PDF and open it
- open the right side bar as well
- in the main pane, start autocomplete by opening a page reference
side note: it would be helpful to bug posters and probably also to logseq contributors working on fixing bugs if some logseq test fixture graphs were already constructed and linked here in the bug report so we could start from a known state when opening bugs.
Expected Behavior
The autocomplete menu appears in the visible area, on top of any other visual elements.
Screenshots
Here is an example that shows substantial occlusion
Desktop or Mobile Platform Information
Mac OS 13.6 on M2, Desktop App Version 0.9.19 (72)
Additional Context
Are you willing to submit a PR? If you know how to fix the bug.
- I'm willing to submit a PR (Thank you!)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the autocomplete menu for a page reference such as [[My Tag]] with the left and right sidebars or a PDF pane open, following the issue's listed steps. Inspect the autocomplete positioning and layering in the affected desktop UI; done means the menu remains fully visible in the active area and appears above the utility panes in each reported context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100