logdna / logdna/setup-chain-node
Provide method of escaping values containing `lookup` identifiers
Open
@mdeltito is already working on this.
Since Jun 18, 2021.
enhancement
good first issue
help wanted
- Dominant language
- JavaScript
- Stars
- 3
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
This is an edge case (and there are ways around it) but consider the following example of a value that starts with a #:
function myAction(opts) {
return this.lookup(opts)
}
chain
.myAction({
id: '!random'
, color: '#cccccc'
})
A couple of options offhand would be:
- Introduce a control character to escape e.g.
\#foo,\!bar - Provide a built-in function that just reflects the value e.g.
!literal("#ccc")- At minimum this is a viable workaround, since quoted function arguments do not pass through
lookup
- At minimum this is a viable workaround, since quoted function arguments do not pass through
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.