logdna / logdna/ruby

log options timestamp is ignored

Open
#45 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
19
Forks
18
PR merge metrics
No merged PRs in 30d

Description

The `timestamp` passed to the `log` method via options here
https://github.com/logdna/ruby/blob/v1.5.0/lib/logdna.rb#L79-L81

is ignored here
https://github.com/logdna/ruby/blob/v1.5.0/lib/logdna/client.rb#L64

Seems that this line should be changed to something like `timestamp: opts[:timestamp]`

Contributor guide

Open the contributing guide

Research direction

Start in lib/logdna.rb around lines 79-81 to trace the timestamp option into lib/logdna/client.rb around line 64. Confirm that the supplied timestamp is used when building the log request, and verify that the request preserves the option value instead of ignoring it.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
observability-sre
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.