logdna / logdna/ruby

Calls to `#log` with progname are swallowed and only progname is sent to LogDNA

Open
#42 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
19
Forks
18
PR merge metrics
No merged PRs in 30d

Description

According to the Ruby docs for the Logger class, #log has a call pattern where a progname is provided and a block is executed only if the log level is high enough to actually log the message.

This call pattern is not supported by this library, and it in fact breaks log messages sent using this method by treating progname as the message and throwing away the message.

If you're using Sentry and wondering why your logs are full of messages that consist solely of "sentry", this is the cause.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the library's handling of Ruby Logger calls and compare it with the linked Ruby Logger documentation for the #log form that accepts a progname and block. Reproduce the Sentry-style call and verify that the block's message is sent to LogDNA rather than only the progname.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
observability-sre
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.