locationtech / locationtech/spatial4j
SpatialContextFactory.initWorldBounds should directly instantiate a Rectangle
Open
Nobody has claimed this yet.
blocker
enhancement
- Dominant language
- Java
- Stars
- 961
- Forks
- 172
- PR merge metrics
- No merged PRs in 30d
Description
It's marked with a TODO and we should do it. In situations where we would need to instantiate a SpatialContext just to create a Shape (which will probably only occur like this when bootstrapping the Context), we should just use RectangleImpl.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at SpatialContextFactory.initWorldBounds and inspect the TODO and the current shape-instantiation path. Replace that bootstrap-time creation with direct RectangleImpl instantiation, then verify the existing project tests still pass and that initWorldBounds returns the expected bounds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100