Remove AbstractDistanceCalculator and simplify distance method

Open
#14 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
backend

Research direction

Start by locating AbstractDistanceCalculator and all distance(Point, double, double) and distance(Point, Point) usages. Check the existing test suite before and after removing the abstract class and coordinate-based overload; done means callers use distance(Point, Point), the old API is gone, and the project still passes its tests.

Written by the indexing model from the issue text.

Description

API

AbstractDistanceCalculator doesn't add anything except redirecting distance(Point, Point) to distance(Point, double, double).

Now that we have reusable Points, we should remove distance(Point, double, double) and just keep distance(Point, Point) (it reads alot better) and remove AbstractDistanceCalculator

Dominant language
Java
Stars
961
Forks
172
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from locationtech/spatial4j

All issues in locationtech/spatial4j

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.