locationtech / locationtech/proj4j
Datum.isEqual maybe have a bug
Open
Nobody has claimed this yet.
bug
- Dominant language
- Java
- Stars
- 232
- Forks
- 86
- PR merge metrics
- No merged PRs in 30d
Description
public boolean isEqual(Datum datum) {
// false if tranforms are not equal
if (getTransformType() != datum.getTransformType()) {
return false;
}
// false if ellipsoids are not (approximately) equal
if (ellipsoid.getEquatorRadius() != ellipsoid.getEquatorRadius()) { // <- maybe have a bug here
if (Math.abs(ellipsoid.getEccentricitySquared()
- datum.ellipsoid.getEccentricitySquared()) > ELLIPSOID_E2_TOLERANCE)
return false;
}
// false if transform parameters are not identical
if (getTransformType() == TYPE_3PARAM || getTransformType() == TYPE_7PARAM) {
for (int i = 0; i < transform.length; i++) {
if (transform[i] != datum.transform[i])
return false;
}
return true;
} else if (getTransformType() == TYPE_GRIDSHIFT) {
return grids.equals(datum.grids);
}
return true; // datums are equal
}
ellipsoid.getEquatorRadius() compare with itself, the condition is always false.
the condition should be
ellipsoid.getEquatorRadius() != datum.ellipsoid.getEquatorRadius()
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Datum.isEqual and inspect the ellipsoid comparison shown in the issue. Add a regression test using datums with different equator radii, then verify that equality rejects them while preserving the existing transform and grid-shift checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100