locationtech / locationtech/jts

Add Collection Type Parameter Declarations for method return values?

Open
#1,113 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

type-question
Dominant language
Java
Stars
2.2k
Forks
475
Avg merge
14d 10h
Merged PRs (30d)
1

Description

Many areas of the codebase return collections without a type parameter declaration (examples below), which introduces the need for superfluous casting in user's code.

Happy to do this myself (at least on the more commonly used areas) -- would you accept a PR for this?

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests, so first locate the commonly used Java methods that return collections without type-parameter declarations, using the examples and image in the report. Done means the selected collection-returning APIs declare their element types and callers no longer need superfluous casts; confirm the affected project tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.