locationtech / locationtech/geotrellis
LayerDeleter does not return information on deleted objects
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.4k
- Forks
- 360
- Avg merge
- 6h 57m
- Merged PRs (30d)
- 12
Description
Description of Request
I have been coming across some difficulties when deleting S3 layers. Having some information on the result of the delete request would be very interesting for implementing additional logic when failures occur.
Proposed Solution
I would like to see the status or even the unsuccessfully deleted objects of the s3Client.deleteObjects request. Something like in the AWS's documentation.
DeleteObjectsResult delObjRes = s3Client.deleteObjects(multiObjectDeleteRequest);
int successfulDeletes = delObjRes.getDeletedObjects().size();
@pomadchin mentionned that all the backends have their corresponding LayerDeleters fand the error encoding should be encoded with all of them.
Describe alternatives you've considered
I am not sure of the direction the effort should take to synchronize all of the backends. I would be happy to contribute to updating the S3 backend.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue mentions LayerDeleter implementations across backends and the S3 client's deleteObjects request, but names no files or tests. First map the LayerDeleter implementations and inspect the S3 deletion call, then define a consistent result or error contract across backends. Done means deletion outcomes are exposed consistently and covered by relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, scala
- Domain
- backend, cloud
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100