locationtech / locationtech/geotrellis

Extent impure behavior

Open
#3,352 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Scala
Stars
1.4k
Forks
360
Avg merge
6h 57m
Merged PRs (30d)
12

Description

At this point Exent can throw an exception on the construction step.

However, the shapely.bbox and the jts.Envelope do the "safe" Envelope consturction by 'swapping' coordinates on the object construction.

Should the Extent behavior be aligned with the jts.Envelope behavior?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with vector/src/main/scala/geotrellis/vector/Extent.scala around lines 93–95, then compare the construction behavior with the linked JTS Envelope implementation and the mentioned shapely.bbox behavior. Determine whether reversed coordinates should be accepted and swapped, and verify that the resulting Extent behavior matches the agreed expectation without the current construction exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.