locationtech / locationtech/geomesa
Clean up duplicate code blocks in Z2/XZ2/Z3/XZ3 IndexKeySpace.getIndexValues()
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.5k
- Forks
- 446
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 31
Description
Clean up duplicate code blocks in Z2/XZ2/Z3/XZ3 IndexKeySpace.getIndexValues()
There is a lot of overlap in the methods, we could pull it out to a super trait or something similar
Original JIRA Issue: https://geomesa.atlassian.net/browse/GEOMESA-2377
Key: GEOMESA-2377
Type: Improvement
Priority: Major
Status: To Do
Resolution: Unresolved
Reporter: Emilio Lahr-Vivaz
Created: Fri, 17 Aug 2018 10:44:01 -0400
Updated: Fri, 17 Aug 2018 10:44:01 -0400
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Z2, XZ2, Z3, and XZ3 IndexKeySpace implementations and compare their getIndexValues() methods. Read the surrounding traits before choosing a shared abstraction; done means the duplicated logic is consolidated while index values remain unchanged and the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100