locationtech / locationtech/geomesa

Arrow - remove jackson dependency

Open
#6,535 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
1.5k
Forks
446
Avg merge
1d 8h
Merged PRs (30d)
31

Description

Arrow - remove jackson dependency

Update Arrow java libs to not use annotations, but to use an external Module for serialization/deserialization. The jackson annotations are only used in the integration tests.

For an example, see: https://github.com/FasterXML/jackson-datatype-joda/blob/jackson-datatype-joda-2.9.9/src/main/java/com/fasterxml/jackson/datatype/joda/JodaModule.java


Original JIRA Issue: https://geomesa.atlassian.net/browse/GEOMESA-2705

Key: GEOMESA-2705
Type: Improvement
Priority: Major
Status: To Do
Resolution: Unresolved
Reporter: Emilio Lahr-Vivaz
Created: Mon, 9 Sep 2019 10:08:12 -0400
Updated: Wed, 15 Apr 2020 10:32:54 -0400


Comments:

557058:48912df4-0004-4f90-9915-db26684ec006 (Tue, 14 Apr 2020 16:04:38 -0400):

Emilio Lahr-Vivaz since we updated Arrow, can we do this ticket?

557058:da7f6dfa-f0a1-468b-aec5-2cb61273feb5 (Tue, 14 Apr 2020 16:58:24 -0400):

we'd have to submit a patch to arrow and then upgrade to a new version once they release.

557058:48912df4-0004-4f90-9915-db26684ec006 (Wed, 15 Apr 2020 10:15:01 -0400):

Do you think they’d go for the patch? Are you interested in working on it? Seems reasonable to me.

557058:da7f6dfa-f0a1-468b-aec5-2cb61273feb5 (Wed, 15 Apr 2020 10:32:54 -0400):

Dunno, they tend to push back on code changes, or let PRs languish. It would save us having to relocate jackson, so not that big a win really. I might do it eventually, maybe before they release 1.0 in the new couple months.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name GeoMesa files; begin by reviewing the Arrow Java libraries and the integration tests that use Jackson annotations. Compare the approach with the referenced JodaModule example and determine the upstream Arrow patch needed. Done means Arrow uses an external serialization module, the annotation dependency is removed, and the integration tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.