locationtech / locationtech/geomesa

Declare supported features when extending GeoMesaDataStore

Open
#6,396 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
1.5k
Forks
446
Avg merge
1d 8h
Merged PRs (30d)
31

Description

Declare supported features when extending GeoMesaDataStore

It might be nice to consolidate various configuration checks, and then have data store declare which features are supported. Currently this is done ad-hoc, with lines like this in createSchema:
if (descriptor.getColumnGroups().nonEmpty) { throw new IllegalArgumentException("Column groups are not supported in this store") }


Original JIRA Issue: https://geomesa.atlassian.net/browse/GEOMESA-2565

Key: GEOMESA-2565
Type: Improvement
Priority: Major
Status: To Do
Resolution: Unresolved
Reporter: Emilio Lahr-Vivaz
Created: Tue, 19 Feb 2019 15:55:17 -0500
Updated: Tue, 19 Feb 2019 15:55:17 -0500

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing GeoMesaDataStore and the createSchema entry point, then locate the existing ad-hoc configuration checks such as the column-groups validation. Compare how datastore implementations currently determine supported features. Done should mean feature support is declared centrally and configuration checks use that declaration consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.