locationtech / locationtech/geomesa

SparkSql explain shouldn't print out connection passwords

Open
#5,932 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Scala
Stars
1.5k
Forks
446
Avg merge
1d 8h
Merged PRs (30d)
31

Description

SparkSql explain shouldn't print out connection passwords

Currently it shows the parameter map, which may include passwords to accumulo.


Original JIRA Issue: https://geomesa.atlassian.net/browse/GEOMESA-2098

Key: GEOMESA-2098
Type: Improvement
Priority: Major
Status: To Do
Resolution: Unresolved
Reporter: Emilio Lahr-Vivaz
Created: Thu, 30 Nov 2017 08:50:52 -0500
Updated: Fri, 17 Apr 2020 13:42:31 -0400


Comments:

557058:48912df4-0004-4f90-9915-db26684ec006 (Fri, 17 Apr 2020 13:30:16 -0400):

Emilio Lahr-Vivaz is this quick to knock out?

557058:da7f6dfa-f0a1-468b-aec5-2cb61273feb5 (Fri, 17 Apr 2020 13:42:31 -0400):

I'm not sure - you're more familiar with the spark code than I am. You could probably just do a find/replace for any key with 'password' in it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the SparkSql explain implementation and the code that renders its parameter map. Start by tracing how connection parameters reach the explain output; done means password values are omitted or masked while the remaining explain information still appears correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala, spark
Domain
data, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.