locationtech / locationtech/geomesa
Add unit tests to ensure ingest from stdin works correctly when inferring various converters
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 1.5k
- Forks
- 446
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 31
Description
Add unit tests to ensure ingest from stdin works correctly when inferring various converters
There are unit tests in the IngestCommandTest class that indirectly call the DelimitedTextConverterFactory.infer(is: InputStream+, sft: OptionSimpleFeatureType, path: OptionString) function, whose path argument is unused. As a result, the tests pass regardless of the value of the path argument.
There are other converter factory classes with their own infer function (e.g. ParquetConverterFactory) that actually use this path argument. It might be helpful to add more unit tests to the IngestCommandTest class to ensure that the ingest works with other converters' inference.
Original JIRA Issue: https://geomesa.atlassian.net/browse/GEOMESA-3328
Key: GEOMESA-3328
Type: Improvement
Priority: Major
Status: To Do
Resolution: Unresolved
Reporter: Adeet Patel
Created: Thu, 25 Jan 2024 13:49:19 -0500
Updated: Thu, 25 Jan 2024 14:03:01 -0500
Related Issues:
- Relates (is depended on by): GEOMESA-3326
Comments:
712020:0d239501-a76e-446a-9f68-cd9eb8f2bbfe (Thu, 25 Jan 2024 14:03:01 -0500):
Created from https://github.com/locationtech/geomesa/pull/3036#discussion_r1466794449
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the IngestCommandTest class and its existing tests that exercise DelimitedTextConverterFactory.infer. Compare that path handling with ParquetConverterFactory.infer, then add stdin-ingest coverage for converters that use the path argument and run the relevant unit tests to confirm inference works correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- cli, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100