localstack / localstack/terraform-local
Using urlparse(AWS_ENDPOINT_URL).scheme
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 323
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
In order to avoid hardcoding the Service endpoint scheme to:
return f"http://{hostname}:{EDGE_PORT}"
Why not adding:
LOCALSTACK_SCHEME = urlparse(AWS_ENDPOINT_URL).scheme or "http"
and then:
return f"{LOCALSTACK_SCHEME}://{hostname}:{EDGE_PORT}"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the code that returns the hardcoded http endpoint and the existing AWS_ENDPOINT_URL handling. Verify how the endpoint scheme should be selected, including the fallback when it is absent, and confirm that the generated LocalStack endpoint uses the expected scheme.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, python, terraform
- Domain
- cli, devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100