Unlisted dependency: `wsproto`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 16
- Forks
- 1
- Avg merge
- 22m
- Merged PRs (30d)
- 2
Description
`wsproto` is [a dependency for](https://github.com/pgjones/hypercorn/blob/84d06b8cf47798d2df7722273341e720ec0ea102/pyproject.toml#L42) `hypercorn`, but [not for](https://github.com/twisted/twisted/blob/trunk/pyproject.toml) `twisted`. So if `rolo` is used only with `twisted`, without installing `hypercorn`, it will fail because of a missing dependency:
> File "/opt/code/localstack/localstack-pro-azure/.venv/lib/python3.11/site-packages/localstack/runtime/server/plugins.py", line 8, in load
from .twisted import TwistedRuntimeServer
File "/opt/code/localstack/localstack-pro-azure/.venv/lib/python3.11/site-packages/localstack/runtime/server/twisted.py", line 2, in
from rolo.serving.twisted import TwistedGateway
File "/opt/code/localstack/localstack-pro-azure/.venv/lib/python3.11/site-packages/rolo/serving/twisted.py", line 20, in
from wsproto import ConnectionType, WSConnection, events
ModuleNotFoundError: No module named 'wsproto'
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pyproject.toml and rolo/serving/twisted.py, then compare the Twisted-only dependency set with the wsproto import shown in the traceback. Verify installation in a Twisted-only environment and confirm that importing TwistedGateway no longer raises ModuleNotFoundError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100