localsend / localsend/protocol

The `cancel` endpoint is called when the user clicks `Close` after the recipient has cancelled the request.

Open
#29 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mermaid
Stars
571
Forks
42
PR merge metrics
No merged PRs in 30d

Description

If the sender tries to send files to a client and the client cancels the request, this is shown on the UI of the sender and the `Cancel` button becomes a `Close` button. However, when the user clicks on the `Close` button, another `cancel` request is sent to the client, which is superfluous since the client already canceled the request themselves.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the sender UI's Close action and the cancel endpoint behavior described in the issue. Confirm that a recipient-cancelled request can be closed without sending another cancel request, then verify the resulting request sequence.

Written by the indexing model from the issue text.

Assessment

Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.