localsend / localsend/protocol
The `cancel` endpoint is called without `sessionId`
Nobody has claimed this yet.
- Dominant language
- Mermaid
- Stars
- 571
- Forks
- 42
- PR merge metrics
- No merged PRs in 30d
Description
I noticed that the cancel endpoint does not contain the session ID. According to the documentation, it should.
When I send one or more files to a client and the client is shown the Decline/Accept popup and at the same time the sender cancels, then the REST endpoint "v2/cancel" is called and not "v2/cancel?sessionId={sessionId}".
I have solved it now by implementing 2 cancel endpoints (I am making a UWP client for Windows 10 Mobile), but it would be nice if this was fixed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the protocol documentation for the cancel operation and trace the request path for v2/cancel. Confirm how the session ID is supplied when the sender cancels during the Decline/Accept popup flow. Done means the request uses v2/cancel?sessionId={sessionId} in that scenario and remains consistent with the documented API.
Written by the indexing model from the issue text.
Assessment
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100