localminimum / localminimum/QANet

mask_logits in layer.py

Open
#43 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
985
Forks
297
PR merge metrics
No merged PRs in 30d

Description

I think the line "return inputs + mask_value * (1 - mask)" should be "return inputs*mask + mask_value * (1 - mask)"

Contributor guide

No contributing guide indexed for this repository

Research direction

Open layer.py and locate mask_logits, then inspect how its mask and mask_value arguments are used around the reported return expression. Verify the intended behavior for masked and unmasked positions, and consider the issue resolved when the implementation matches that behavior and the repository's relevant checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, tensorflow
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.