lobsters / lobsters/mockturtle

The new invitation info/reminder needs to calm down.

Open
#23 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
17
Forks
8
PR merge metrics
No merged PRs in 30d

Description

I just got this after reconnecting (all times CEST)

[13:51:57] <mockturtle> Looking for an invitation wink? https://lobste.rs/about#invitations has an intro, and https://lobste.rs/chat explains some expectations for this channel. (I am the channel bot.)
[13:51:57] <mockturtle> Looking for an invitation wink? https://lobste.rs/about#invitations has an intro, and https://lobste.rs/chat explains some expectations for this channel. (I am the channel bot.)
[13:51:57] <mockturtle> Looking for an invitation wink? https://lobste.rs/about#invitations has an intro, and https://lobste.rs/chat explains some expectations for this channel. (I am the channel bot.)
[13:51:57] <mockturtle> Looking for an invitation wink? https://lobste.rs/about#invitations has an intro, and https://lobste.rs/chat explains some expectations for this channel. (I am the channel bot.)

We assume these were triggered by one of my lines hours earlier:

[11:21:38] <wink> .. invited ..
[11:23:38] <wink> .. invitee .. invited ..
[11:23:55] <wink> .. inviting ..
[11:24:38] <wink> .. invitees ..
  • too eager
  • not ignoring users who talk about invites, inviting, etc. which can also happen by this imagined dialog:
<a> Hi, can I get an invite?
...
<b> a: I have sent you an invite

Not sure how to fix it, the idea was good. But it needs at least a debounce and maybe even ignore users with > 100 lines. (not sure if worth keeping a hashmap of (md5(nick), count), maybe until restart is fine)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name the files or tests containing the invitation reminder; start by locating the logic that emits the “Looking for an invitation” message and reviewing how chat lines are matched. Reproduce the repeated messages from the examples, then verify that reminders are debounced and ordinary invitation-related conversation does not trigger repeated notices.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.