lnls-dig / lnls-dig/openMMC

Move vTaskPayload from board specific directory to a generic implementation in modules/

Open
#132 0 comments 0 reactions 0 assignees View on GitHub
afc-bpm afc-timing afcv4 enhancement
Dominant language
C
Stars
46
Forks
34
PR merge metrics
No merged PRs in 30d

Description

The is a lot of duplicated code on [port/board/afc-bpm/v3_1/payload.c](https://github.com/lnls-dig/openMMC/blob/eddf4fb4860ad58d5c8e150b3c99a8b379dd29fa/port/board/afc-bpm/v3_1/payload.c), [port/board/afc-fofb-ctrl/v3_1/payload.c](https://github.com/lnls-dig/openMMC/blob/eddf4fb4860ad58d5c8e150b3c99a8b379dd29fa/port/board/afc-fofb-ctrl/v3_1/payload.c), [port/board/afc-timing/payload.c](https://github.com/lnls-dig/openMMC/blob/eddf4fb4860ad58d5c8e150b3c99a8b379dd29fa/port/board/afc-timing/payload.c) and [port/board/afc-v4/payload.c](https://github.com/lnls-dig/openMMC/blob/eddf4fb4860ad58d5c8e150b3c99a8b379dd29fa/port/board/afc-v4/payload.c). This can be unified in a single generic implementation of vTaskPayload that calls board specific functions for managing the payload power.

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the duplicated implementations in port/board/afc-bpm/v3_1/payload.c, port/board/afc-fofb-ctrl/v3_1/payload.c, port/board/afc-timing/payload.c, and port/board/afc-v4/payload.c. Identify the shared vTaskPayload logic and the board-specific payload power functions, then inspect modules/ for the appropriate generic implementation location. Done means vTaskPayload is unified in modules/ while board-specific power management remains available through board functions.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
embedded-iot
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.