lnccbrown / lnccbrown/ssm-simulators
Consider using tuple instead of list in ssms/basic_simulators/simulator bin_artbitrary_fptd
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 24
- Forks
- 18
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 9
Description
```
choice_codes: list[float] = [-1.0, 1.0], # TODO: use tuple instead of list
```
In file ssms/basic_simulators/simulator.py
https://github.com/lnccbrown/ssm-simulators/blob/b04d824839dc63bf0d50af48805bd8a95de960e7/ssms/basic_simulators/simulator.py#L436
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open ssms/basic_simulators/simulator.py at line 436 and inspect the choice_codes declaration. Check the surrounding simulator usage to confirm the value is not modified, then run the project's existing checks. Done means the declaration uses an immutable tuple consistently without changing simulator behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100