lnccbrown / lnccbrown/ssm-simulators
drop use of `locals` in simulator()
Open
Nobody has claimed this yet.
linear-ssm-simulators
refactor
- Dominant language
- Jupyter Notebook
- Stars
- 24
- Forks
- 18
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 9
Description
[Here](https://github.com/AlexanderFengler/ssm-simulators/blob/main/ssms/basic_simulators/simulator.py#L678-L686) we are using `locals()` inside the simulator function.
Should be refactored to avoid that call.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open ssms/basic_simulators/simulator.py at lines 678-686 and read the surrounding simulator() implementation to understand the current locals() use. Refactor that section without locals(), then run the relevant simulator tests or existing test suite to confirm behavior is unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100