lnccbrown / lnccbrown/ssm-simulators
Unify data persistence in `lan_mlp` and `snpe`
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 24
- Forks
- 18
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 9
Description
There are identical workflows for this task in classes defined in these modules.
- [ ] Move the relevant business logic to a dedicated method or function in `DataGenerator` class
Soon there will be separate methods to selectively persist data as opposed to the full object. Added benefit: `DataGeneratorSNPE` inherits from `DataGenerator`.
Thoughts? @AlexanderFengler @krishnbera
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the DataGenerator and DataGeneratorSNPE class definitions in the lan_mlp and snpe modules. Compare their identical persistence workflows and identify the business logic that belongs in DataGenerator. Done means the duplicated workflow is unified through inheritance while preserving the current persistence behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100