lnccbrown / lnccbrown/HSSM

Add `ddm_sdv` onnx model to 🤗

Open
#412 3 comments 0 reactions 1 assignee View on GitHub

@AlexanderFengler is already working on this.

Since May 7, 2024.

bug
Dominant language
Python
Stars
124
Forks
24
Avg merge
19h 32m
Merged PRs (30d)
60

Description

**HSSM version**
0.2.0

**To Reproduce**
```
import numpy
import hssm
hssm.set_floatX("float32")
cav_data = hssm.load_data("cavanagh_theta")
```

**Bug 1:** Bounds by default
```
ddm_model = hssm.HSSM(
data=cav_data,
model='ddm_sdv',
p_outlier=0.05,
)
```
Output:
```
ValueError: Please specify the prior or bounds for sv.
```
I think this should be solved by using the right bounds variable in `defaults.py` - which I see has happened in `main` brain, but please confirm.

**Bug 2:** So I proceeded to explicitly give the bounds, but.
```
ddm_model = hssm.HSSM(
data=cav_data,
model='ddm_sdv',
p_outlier=0.05,
include=[
{
"name": "sv",
"bounds": (0, numpy.inf),
},
],
)
ddm_model.sample()
```
Output:
```
TypeError: Invalid dtype for variable sv_interval__. Can not cast to float32 with casting rule no.
```
Unsure what is causing this.

**Bug 3:** So I moved to `approx_differentiable`, but.
```
ddm_model = hssm.HSSM(
data=cav_data,
model='ddm_sdv',
loglik_kind='approx_differentiable',
p_outlier=0.05,
)
```
Output:
```
Entry Not Found for url: https://huggingface.co/franklab/HSSM/resolve/main/ddm_sdv.onnx.
```
I guess the compiled version from Huggingface was removed?

So I moved to `blackbox` likelihood, but for my actual use case, I have a hierarchical model for `t` parameter and I am facing the same issue as #411, i.e., high r-hats for all `t` parameters :(

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.