lmcinnes / lmcinnes/pynndescent
Add support for nan_euclidean distance metric
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 970
- Forks
- 107
- PR merge metrics
- No merged PRs in 30d
Description
Really excited to work with this repo! Thanks for all the work, maintainers!
I'm interested in adapting the [KNNImputer](https://scikit-learn.org/stable/modules/generated/sklearn.impute.KNNImputer.html) of sklearn to get some benefit from pynndescent, if possible. It uses a metric it calls `nan_euclidean`:
https://scikit-learn.org/stable/modules/generated/sklearn.metrics.pairwise.nan_euclidean_distances.html
Would it be welcome (or even sensible, because maybe there's no benefit here) for someone to submit a PR to bring a version of `nan_euclidean` into pynndescent?
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no repository files, tests, or entry points. Start by reviewing pynndescent's existing metric support alongside sklearn's KNNImputer and nan_euclidean_distances documentation; determine whether the metric is compatible and beneficial, then define tests and acceptance criteria before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100