lmammino / lmammino/jQueryNiftyBorders

Elements "nifted" inside an "a" tag are not clickable in ie6 and ie7

Open
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug ie6 ie7
Dominant language
JavaScript
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

suppose you have the following markup:

<div class="preview">
    <a href="#">
        <img src="image.jpg" alt="hello world" />
    </a>
</div>

and you calls

$("#preview a img").niftyBorders();

the markup will be changed to:

<div class="preview">
    <a href="#">
        <div class="nb_container" style="...">
            <img src="image.jpg" alt="hello world" >
            <div class="nb_borders" style="..."></div>
        </div>
    </a>
</div>

This kind of markup is not valid and the link do not work on ie6 and ie7

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the provided markup and the $("#preview a img").niftyBorders() call in IE6 or IE7. Inspect the plugin code that transforms the image into the nb_container and nb_borders structure. Done means links containing nifted images remain clickable while the animated border behavior still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.