lm-sys / lm-sys/FastChat

compute_bootstrap_elo illegal arguments?

Open
#3,769 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
39.5k
Forks
4.8k
PR merge metrics
No merged PRs in 30d

Description

I'm trying to look into bits of the codebase that calculate the scores.

This calls compute_bootstrap_elo with argument num_cpu

https://github.com/lm-sys/FastChat/blob/587d5cfa1609a43d192cedb8441cac3c17db105d/fastchat/serve/monitor/elo_analysis.py#L386C1-L388C10

But in the definition of the function, no argument is called num_cpu

https://github.com/lm-sys/FastChat/blob/587d5cfa1609a43d192cedb8441cac3c17db105d/fastchat/serve/monitor/rating_systems.py#L153C1-L155C2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the compute_bootstrap_elo call in fastchat/serve/monitor/elo_analysis.py with its definition in fastchat/serve/monitor/rating_systems.py, focusing on the num_cpu argument. Trace the call to determine the intended interface, then verify that the corrected usage or definition preserves the Elo analysis behavior and add coverage if the repository provides a relevant test location.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ai
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.