Unreachable code in `get_worker_address`
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 39.5k
- Forks
- 4.8k
- PR merge metrics
- No merged PRs in 30d
Description
This code, https://github.com/lm-sys/FastChat/blob/d04ce6453ae016d9e03626b679c07aa1388dcbee/fastchat/serve/controller.py#L175, is unreachable. Is that expected?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading fastchat/serve/controller.py around get_worker_address and the referenced line 175, then trace how the function is called and how control reaches that section. Confirm whether the code is intentionally unreachable; done means clarifying the behavior and resolving the issue with the appropriate code change or explanation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ai, backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100