`fastchat.serve.controller` stops working after a while
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 39.5k
- Forks
- 4.8k
- PR merge metrics
- No merged PRs in 30d
Description
After running for a while, fastchat.serve.controller stops working for me with a RecursionError
Stacktrace
File "C:\Program Files\Python310\lib\logging\__init__.py", line 1547, in log
self._log(level, msg, args, **kwargs)
File "C:\Program Files\Python310\lib\logging\__init__.py", line 1624, in _log
self.handle(record)
File "C:\Program Files\Python310\lib\logging\__init__.py", line 1634, in handle
self.callHandlers(record)
File "C:\Program Files\Python310\lib\logging\__init__.py", line 1696, in callHandlers
hdlr.handle(record)
File "C:\Program Files\Python310\lib\logging\__init__.py", line 968, in handle
self.emit(record)
File "C:\Program Files\Python310\lib\logging\handlers.py", line 77, in emit
self.handleError(record)
File "C:\Program Files\Python310\lib\logging\__init__.py", line 1021, in handleError
sys.stderr.write('--- Logging error ---\n')
File "~\repo_fastchat\fastchat\utils.py", line 108, in write
self.logger.log(self.log_level, encoded_message.rstrip())
Details
OS: Windows Server 2022
Python: 3.10.11
Fastchat: 0.2.36
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with fastchat.serve.controller and fastchat/utils.py at line 108, then reproduce the long-running controller failure on the reported Python and Windows environment. Trace why logging reaches write() recursively; done means the controller continues operating without the reported RecursionError.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100