lm-sys / lm-sys/FastChat

Add new vllm serving options

Open
#2,709 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
39.5k
Forks
4.8k
PR merge metrics
No merged PRs in 30d

Description

I would like to propose to add a new system to to serve vllm workers so that all its capabilities are exposed. Currently there is no support for greedy search and beamsearch from vllm workers.

I have done modifying the chat completion endpoint. However, it is specifically written for vllm workers, not the transformers model_workers.

The preliminary code can be found at
https://github.com/tjtanaa/fastchat-serve/tree/vllm-api-expose-tj

Custom OpenAI API server with best_of, use_beam_search
https://github.com/tjtanaa/fastchat-serve/blob/vllm-api-expose-tj/src/fastchat_serve/openai_api_server_vllm.py

Modified vllm worker to support greedy search and beam search.
https://github.com/tjtanaa/fastchat-serve/blob/vllm-api-expose-tj/src/fastchat_serve/vllm_worker.py

Would this be helpful?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the referenced fastchat_serve/openai_api_server_vllm.py and fastchat_serve/vllm_worker.py changes, then compare them with the current vLLM serving and chat completion entry points. Done means vLLM workers expose the requested greedy and beam-search capabilities, including the proposed options, with behavior covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ai, api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.