[Feat] Add feature checking the network connection
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 39.5k
- Forks
- 4.8k
- PR merge metrics
- No merged PRs in 30d
Description
When trying to run model_worker we have to write worker_address and host and port.
It seems that Fastchat gives an error when I cannot connect to the worker_address if it is not available.
So I think a new feature is needed to check if worker_address and host+port are available to connect by using try, exception.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the model_worker entry point and trace how worker_address and host+port are used when connecting. Reproduce the unavailable-worker case and clarify the expected handling; done should include a defined connection check that reports unavailable endpoints without the current error behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100