[train flant5] Preprocessing the conversations dataset is too slow.
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 39.5k
- Forks
- 4.8k
- PR merge metrics
- No merged PRs in 30d
Description
for source in sources:
conversation = _add_speaker_and_signal(header, source, tokenizer)
conversations.append(conversation)
Passing the tokenizer object as a boolean argument makes the operation slow (1000X).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in fastchat/train/train_flant5.py around line 236 and inspect how _add_speaker_and_signal receives the tokenizer argument. Reproduce the preprocessing timing with the current call, then verify that the corrected argument handling removes the severe slowdown without changing conversation preprocessing results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100